On Mon, 6 Jun 2022 at 16:51, Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> wrote:
>
> On Thu 02 Jun 00:08 PDT 2022, Dmitry Baryshkov wrote:
> > -static const struct of_device_id qcom_qmp_phy_of_match_table[] = {
> [..]
> > - }, {
> > - .compatible = "qcom,sdm845-qmp-usb3-phy",
>
> We have a few examples of these, where we have a compatible for the
> USB-half of the combo PHY. For backwards compatibility I think we would
> want to retain these, but if we move them to the UNI phy driver wouldn't
> we end up with duplicate USB configuration tables between the two files?
Yes. Unlike previous approaches (RFC v1, v2) this series ends up with
duplicate USB configuration tables for these three PHYs. We can export
them from -combo and use them in the -usb driver.
In previous attempts I tried to use the USB subdriver from the combo
one. However at this point I'd prefer first to sort out the combo PHY
init/reinit/switch issues, fix the register layout for the USB parts
and remove duplication afterwards.
>
> Should we keep the combo instances here as well?
We keep combo instances in qcom_qmp_combo_phy_of_match_table.
>
> Regards,
> Bjorn
>
> > - .data = &qmp_v3_usb3phy_cfg,
> > - }, {
--
With best wishes
Dmitry
