Re: [PATCH] arm64: dts: qcom: sc7280: Enable keyboard backlight for villager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 20, 2022 at 12:57:50PM -0700, Doug Anderson wrote:
> Hi,
> 
> On Fri, May 20, 2022 at 12:48 PM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote:
> >
> > Villager has a backlit keyboard, enable support for the backlight.
> >
> > Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
> > ---
> >
> >  arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts | 8 ++++++++
> >  arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi            | 2 +-
> >  2 files changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts
> > index d3d6ffad4eff..b6a6a1454883 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts
> > @@ -58,6 +58,10 @@ &ap_sar_sensor1 {
> >         status = "okay";
> >  };
> >
> > +&keyboard_backlight {
> > +       status = "okay";
> > +};
> 
> Instead of doing this, can you just get rid of the status = "disabled"
> in herobrine.dtsi? I don't think there's any benefit to having two
> levels of "disabled" in the herobrine device tree.

Sure.

I guess the 'disabled' status was put as a micro-optimization to avoid
probing the 'pwm-leds' driver on boards that don't have any such LEDs. In
practical terms it shouldn't really make a difference in terms of memory
or CPU.



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux