Hi, On Fri, May 20, 2022 at 12:48 PM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote: > > Villager has a backlit keyboard, enable support for the backlight. > > Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx> > --- > > arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts | 8 ++++++++ > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 +- > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts > index d3d6ffad4eff..b6a6a1454883 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts > @@ -58,6 +58,10 @@ &ap_sar_sensor1 { > status = "okay"; > }; > > +&keyboard_backlight { > + status = "okay"; > +}; Instead of doing this, can you just get rid of the status = "disabled" in herobrine.dtsi? I don't think there's any benefit to having two levels of "disabled" in the herobrine device tree.