On 19/05/2022 12:01, Krzysztof Kozlowski wrote: > On 19/05/2022 11:57, Yassine Oudjana wrote: >>> >>> There is no such property documented. Either add bindings, or drop. >>> >>>> + qcom,board-id = <47 0>; >>> >>> >>> The same. >> >> These properties are already used in many device trees; they are >> needed to let the bootloader pick a DTB, but yes they aren't >> documented currently. devicetree/bindings/arm/qcom.yaml would >> probably be a good place to put them. > > Which means each person is using them and not caring about > documenting... they need to be documented. I am not even sure if they > should be accepted. > > The DTS describes hardware, not bootloader specific details. The > hardware - board - is defined by compatible and bootloader should use > it. Adding new properties because someone decided "I don't like > compatibles" is not appropriate. There is prior art: https://lkml.org/lkml/2015/10/26/651 https://lore.kernel.org/all/CAL_JsqJAOEvs08Jydn9wWtM7-Oxd=MmmDER48VRF7z3Gkzt0CQ@xxxxxxxxxxxxxx/ Best regards, Krzysztof
