2014-09-10 20:54 GMT+09:00 Dolev Raviv <draviv@xxxxxxxxxxxxxx>:
> +static inline void ufshcd_enable_irq(struct ufs_hba *hba)
> +{
> + if (!hba->is_irq_enabled) {
> + enable_irq(hba->irq);
> + hba->is_irq_enabled = true;
> + }
> +}
> +
> +static inline void ufshcd_disable_irq(struct ufs_hba *hba)
> +{
> + if (hba->is_irq_enabled) {
> + disable_irq(hba->irq);
> + hba->is_irq_enabled = false;
> + }
> +}
This IRQ could be shared among several devices because it is requested
with IRQF_SHARED. So enable_irq()/disable_irq() should be replaced with
request_irq()/free_irq()? Otherwise other devices which share the same
IRQ will be malfunction while disabling IRQ.
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
