These functions are ringing the channel and event ring doorbells based on the doorbell mode configured. So in order to better reflect their functionality, let's rename them to mhi_ring_db_brstmode() and mhi_ring_db_no_brstmode(). Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> --- drivers/bus/mhi/host/init.c | 8 ++++---- drivers/bus/mhi/host/internal.h | 4 ++-- drivers/bus/mhi/host/main.c | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/bus/mhi/host/init.c b/drivers/bus/mhi/host/init.c index 50d2a1f66e5e..e095d2999c06 100644 --- a/drivers/bus/mhi/host/init.c +++ b/drivers/bus/mhi/host/init.c @@ -669,9 +669,9 @@ static int parse_ev_cfg(struct mhi_controller *mhi_cntrl, goto error_ev_cfg; if (mhi_event->db_cfg.brstmode == MHI_DB_BRST_ENABLE) - mhi_event->db_cfg.ring_db = mhi_db_brstmode; + mhi_event->db_cfg.ring_db = mhi_ring_db_brstmode; else - mhi_event->db_cfg.ring_db = mhi_db_brstmode_disable; + mhi_event->db_cfg.ring_db = mhi_ring_db_no_brstmode; mhi_event->data_type = event_cfg->data_type; @@ -806,9 +806,9 @@ static int parse_ch_cfg(struct mhi_controller *mhi_cntrl, } if (mhi_chan->db_cfg.brstmode == MHI_DB_BRST_ENABLE) - mhi_chan->db_cfg.ring_db = mhi_db_brstmode; + mhi_chan->db_cfg.ring_db = mhi_ring_db_brstmode; else - mhi_chan->db_cfg.ring_db = mhi_db_brstmode_disable; + mhi_chan->db_cfg.ring_db = mhi_ring_db_no_brstmode; mhi_chan->configured = true; diff --git a/drivers/bus/mhi/host/internal.h b/drivers/bus/mhi/host/internal.h index 3305f4d93580..007c7554439f 100644 --- a/drivers/bus/mhi/host/internal.h +++ b/drivers/bus/mhi/host/internal.h @@ -309,9 +309,9 @@ static inline void mhi_trigger_resume(struct mhi_controller *mhi_cntrl) } /* Register access methods */ -void mhi_db_brstmode(struct mhi_controller *mhi_cntrl, struct db_cfg *db_cfg, +void mhi_ring_db_brstmode(struct mhi_controller *mhi_cntrl, struct db_cfg *db_cfg, void __iomem *db_addr, dma_addr_t db_val); -void mhi_db_brstmode_disable(struct mhi_controller *mhi_cntrl, +void mhi_ring_db_no_brstmode(struct mhi_controller *mhi_cntrl, struct db_cfg *db_mode, void __iomem *db_addr, dma_addr_t db_val); int __must_check mhi_read_reg(struct mhi_controller *mhi_cntrl, diff --git a/drivers/bus/mhi/host/main.c b/drivers/bus/mhi/host/main.c index c46bd2dd546b..28b41621e004 100644 --- a/drivers/bus/mhi/host/main.c +++ b/drivers/bus/mhi/host/main.c @@ -87,7 +87,7 @@ void mhi_write_db(struct mhi_controller *mhi_cntrl, void __iomem *db_addr, mhi_write_reg(mhi_cntrl, db_addr, 0, lower_32_bits(db_val)); } -void mhi_db_brstmode(struct mhi_controller *mhi_cntrl, +void mhi_ring_db_brstmode(struct mhi_controller *mhi_cntrl, struct db_cfg *db_cfg, void __iomem *db_addr, dma_addr_t db_val) @@ -99,7 +99,7 @@ void mhi_db_brstmode(struct mhi_controller *mhi_cntrl, } } -void mhi_db_brstmode_disable(struct mhi_controller *mhi_cntrl, +void mhi_ring_db_no_brstmode(struct mhi_controller *mhi_cntrl, struct db_cfg *db_cfg, void __iomem *db_addr, dma_addr_t db_val) -- 2.25.1