On Fri, 29 Apr 2022 at 18:59, Ansuel Smith <ansuelsmth@xxxxxxxxx> wrote: > > On Fri, Apr 29, 2022 at 10:53:16AM -0500, Rob Herring wrote: > > On Fri, 29 Apr 2022 14:17:39 +0200, Ansuel Smith wrote: > > > Convert kpss-gcc driver Documentation to yaml. > > > > > > Signed-off-by: Ansuel Smith <ansuelsmth@xxxxxxxxx> > > > --- > > > .../bindings/arm/msm/qcom,kpss-gcc.txt | 44 ------------- > > > .../bindings/arm/msm/qcom,kpss-gcc.yaml | 63 +++++++++++++++++++ > > > 2 files changed, 63 insertions(+), 44 deletions(-) > > > delete mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.txt > > > create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml: properties: '#clock-cells' is a dependency of 'clock-output-names' > > Erm how to fix this? I can't do a 1:1 conversion if the source was > wrong and also have no bot warning. > Or I should just push an additional patch to fix this error after the > conversion? You can fix obvious simple mistakes and describe your chains in the commit message. > > > from schema $id: http://devicetree.org/meta-schemas/clocks.yaml# > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml: ignoring, error in schema: properties > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.example.dtb: clock-controller@2011000: '#clock-cells' is a dependency of 'clock-output-names' > > From schema: /usr/local/lib/python3.10/dist-packages/dtschema/schemas/clock/clock.yaml > > Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.example.dtb:0:0: /example-0/clock-controller@2011000: failed to match any schema with compatible: ['qcom,kpss-gcc-ipq8064', 'qcom,kpss-gcc'] > > Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.example.dtb:0:0: /example-0/clock-controller@2011000: failed to match any schema with compatible: ['qcom,kpss-gcc-ipq8064', 'qcom,kpss-gcc'] > > > > doc reference errors (make refcheckdocs): > > > > See https://patchwork.ozlabs.org/patch/ > > > > This check can fail if there are any dependencies. The base for a patch > > series is generally the most recent rc1. > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > date: > > > > pip3 install dtschema --upgrade > > > > Please check and re-submit. > > > > -- > Ansuel -- With best wishes Dmitry
