Re: [PATCH v9 11/12] arm64: dts: qcom: sc7280: Add sound node for CRD 1.0 and CRD 2.0

[Srinivasa Rao Mandadapu <quic_srivasam@xxxxxxxxxxx>]

On 4/21/2022 11:26 PM, Matthias Kaehlcke wrote:
Thanks for your time Matthias!!!
> On Thu, Apr 21, 2022 at 08:17:38PM +0530, Srinivasa Rao Mandadapu wrote:
>
> > Subject: arm64: dts: qcom: sc7280: Add sound node for CRD 1.0 and CRD 2.0
> nit: and the IDP boards?
Okay.
> > Add dt nodes for sound card support on revision 3 and 4
> > (aka CRD 1.0 and 2.0) boards, which is using WCD938x headset
> > playback, capture, I2S speaker playback and DMICs via VA macro.
> >
> > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@xxxxxxxxxxx>
> > Co-developed-by: Venkata Prasad Potturu <quic_potturu@xxxxxxxxxxx>
> > Signed-off-by: Venkata Prasad Potturu <quic_potturu@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts | 23 +++++++
> >   arch/arm64/boot/dts/qcom/sc7280-idp.dtsi   | 98 ++++++++++++++++++++++++++++++
> >   2 files changed, 121 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
> > index 462d655..763d2bf 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
> > @@ -87,6 +87,29 @@ ap_ts_pen_1v8: &i2c13 {
> >   	pins = "gpio51";
> >   };
> >   
> > +&sound {
> > +	audio-routing =
> > +		"IN1_HPHL", "HPHL_OUT",
> > +		"IN2_HPHR", "HPHR_OUT",
> > +		"AMIC1", "MIC BIAS1",
> > +		"AMIC2", "MIC BIAS2",
> > +		"VA DMIC0", "MIC BIAS1",
> > +		"VA DMIC1", "MIC BIAS1",
> > +		"VA DMIC2", "MIC BIAS3",
> > +		"VA DMIC3", "MIC BIAS3",
> > +		"TX SWR_ADC0", "ADC1_OUTPUT",
> > +		"TX SWR_ADC1", "ADC2_OUTPUT",
> > +		"TX SWR_ADC2", "ADC3_OUTPUT",
> > +		"TX SWR_DMIC0", "DMIC1_OUTPUT",
> > +		"TX SWR_DMIC1", "DMIC2_OUTPUT",
> > +		"TX SWR_DMIC2", "DMIC3_OUTPUT",
> > +		"TX SWR_DMIC3", "DMIC4_OUTPUT",
> > +		"TX SWR_DMIC4", "DMIC5_OUTPUT",
> > +		"TX SWR_DMIC5", "DMIC6_OUTPUT",
> > +		"TX SWR_DMIC6", "DMIC7_OUTPUT",
> > +		"TX SWR_DMIC7", "DMIC8_OUTPUT";
> > +};
> > +
> >   &wcd938x {
> >   	pinctrl-names = "default", "sleep", "us_euro_hs_sel";
> >   	pinctrl-0 = <&wcd_reset_n>;
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> > index 2e991e8..f2ad0c6 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> > @@ -85,6 +85,104 @@
> >   		pinctrl-names = "default";
> >   		pinctrl-0 = <&nvme_pwren>;
> >   	};
> > +
> > +	sound: sound {
> > +		compatible = "google,sc7280-herobrine";
> > +		model = "sc7280-wcd938x-max98360a-1mic";
> > +
> > +		audio-routing =
> > +			"IN1_HPHL", "HPHL_OUT",
> > +			"IN2_HPHR", "HPHR_OUT",
> > +			"AMIC1", "MIC BIAS1",
> > +			"AMIC2", "MIC BIAS2",
> > +			"VA DMIC0", "MIC BIAS3",
> > +			"VA DMIC1", "MIC BIAS3",
> > +			"VA DMIC2", "MIC BIAS1",
> > +			"VA DMIC3", "MIC BIAS1",
> > +			"TX SWR_ADC0", "ADC1_OUTPUT",
> > +			"TX SWR_ADC1", "ADC2_OUTPUT",
> > +			"TX SWR_ADC2", "ADC3_OUTPUT",
> > +			"TX SWR_DMIC0", "DMIC1_OUTPUT",
> > +			"TX SWR_DMIC1", "DMIC2_OUTPUT",
> > +			"TX SWR_DMIC2", "DMIC3_OUTPUT",
> > +			"TX SWR_DMIC3", "DMIC4_OUTPUT",
> > +			"TX SWR_DMIC4", "DMIC5_OUTPUT",
> > +			"TX SWR_DMIC5", "DMIC6_OUTPUT",
> > +			"TX SWR_DMIC6", "DMIC7_OUTPUT",
> > +			"TX SWR_DMIC7", "DMIC8_OUTPUT";
> > +
> > +		qcom,msm-mbhc-hphl-swh = <1>;
> > +		qcom,msm-mbhc-gnd-swh = <1>;
> > +
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +		#sound-dai-cells = <0>;
> > +
> > +		dai-link@0 {
> > +			link-name = "MAX98360A";
> > +			reg = <MI2S_SECONDARY>;
> This usually is the same as the node address. Given that it's a bogus value that
> isn't used the link number seems a better choice than the lpass DAI id.
Okay. Will update reg property with link number.
> Note for other reviewers: the current state of discussion is to remove this
> property from the binding and device trees in a follow up series.
>
> > +
> > +			cpu {
> > +				sound-dai = <&lpass_cpu MI2S_SECONDARY>;
> > +			};
> > +
> > +			codec {
> > +				sound-dai = <&max98360a>;
> > +			};
> > +		};
> > +
> > +		dai-link@1 {
> > +			link-name = "DisplayPort";
> > +			reg = <LPASS_DP_RX>;
> > +
> > +			cpu {
> > +				sound-dai = <&lpass_cpu LPASS_DP_RX>;
> > +			};
> > +
> > +			codec {
> > +				sound-dai = <&mdss_dp>;
> > +			};
> > +		};
> > +
> > +		dai-link@2 {
> > +			link-name = "WCD9385 Playback";
> > +			reg = <LPASS_CDC_DMA_RX0>;
> > +
> > +			cpu {
> > +				sound-dai = <&lpass_cpu LPASS_CDC_DMA_RX0>;
> > +			};
> > +
> > +			codec {
> > +				sound-dai = <&wcd938x 0>, <&swr0 0>, <&lpass_rx_macro 0>;
> > +			};
> > +		};
> > +
> > +		dai-link@3 {
> > +			link-name = "WCD9385 Capture";
> > +			reg = <LPASS_CDC_DMA_TX3>;
> > +
> > +			cpu {
> > +				sound-dai = <&lpass_cpu LPASS_CDC_DMA_TX3>;
> > +			};
> > +
> > +			codec {
> > +				sound-dai = <&wcd938x 1>, <&swr1 0>, <&lpass_tx_macro 0>;
> > +			};
> > +		};
> > +
> > +		dai-link@4 {
> > +			link-name = "DMIC";
> > +			reg = <LPASS_CDC_DMA_VA_TX0>;
> > +
> > +			cpu {
> > +				sound-dai = <&lpass_cpu LPASS_CDC_DMA_VA_TX0>;
> > +			};
> > +
> > +			codec {
> > +				sound-dai = <&lpass_va_macro 0>;
> > +			};
> > +		};
> > +	};
> >   };
> >   
> >   &apps_rsc {
> > --
> > 2.7.4