Jun Nie <jun.nie@xxxxxxxxxx> 于2022年4月20日周三 17:57写道：
>
> > >>
> > >> Generic node names, no underscores in node names. This applies everywhere.
> > >>
> > >>> + compatible = "qcom,qfprom";
> > >>> + reg = <0x00058000 0x1000>;
> > >>> + #address-cells = <1>;
> > >>> + #size-cells = <1>;
> > >>> + cpr_efuse_init_voltage1: ivoltage1@dc {
> > >>
> > >> s/ivoltageX/voltage/
> > >
> > > How about cpr_efuse_init_voltage_dc? There are 3
> > > cpr_efuse_init_voltage* node here.
> >
> > The node names should be generic, so this should be maybe even just
> > "efuse"? Feel free to add some prefix to it, so "init-voltage-efuse",
> > but no underscores and no suffixes in such case (but "init-voltage2-efuse").
>
> The nodes are referenced by other node, such as below case. So I have
> to name them,
> underscore is the best separator. While I have 3 init_voltage related
> nodes to name.
> What's the name you suggest for them?
>
> arch/arm/boot/dts/qcom-apq8084.dtsi: nvmem-cells = <&tsens_calib>,
> <&tsens_backup>;
>
Maybe it should like this?
cpr_efuse_init_voltage1: efuse {
> Regards,
> Jun
