On 4/6/2022 12:38 AM, Stephen Boyd wrote:
Quoting Satya Priya (2022-04-05 06:50:30)
Add mfd cell struct to match with the "qcom,pm8008-regulator"
driver and a separate probe to add pm8008_regulator_devs.
This separate probe is required to ensure the regulators are
registered only with the mfd device which contains regulators.
I don't get it. Shouldn't the pm8008-regulators compatible string be a
different i2c driver in drivers/regulator/ that matches the compatible
string for qcom,pm8008-regulators?
Initially we had it that way but as per Mark's suggestion here [1] I've
made these changes to register regulators directly through mfd driver.
[1]
https://patchwork.kernel.org/project/linux-arm-msm/patch/1637314953-4215-3-git-send-email-quic_c_skakit@xxxxxxxxxxx/#24618011
Add the reset-gpio toggling in the pm8008_probe() to bring
pm8008 chip out of reset instead of doing it in DT node using
"output-high" property.
Please split this part off to a different patch.
Okay.
