Hi, On Thu, Mar 24, 2022 at 3:12 PM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote: > > On Thu, Mar 24, 2022 at 12:59:51PM -0700, Doug Anderson wrote: > > Hi, > > > > On Thu, Mar 24, 2022 at 10:13 AM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote: > > > > > > Add a basic device tree for the herobrine villager board. > > > > > > Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx> > > > --- > > > > > > arch/arm64/boot/dts/qcom/Makefile | 1 + > > > .../dts/qcom/sc7280-herobrine-villager-r0.dts | 274 ++++++++++++++++++ > > > 2 files changed, 275 insertions(+) > > > > Question: how does this interact with the patch: > > > > https://lore.kernel.org/r/20220316172814.v1.3.Iad21bd53f3ac14956b8dbbf3825fc7ab29abdf97@changeid/ > > > > Specifically, if that patch lands first don't you need to add a patch > > to turn on "pp3300_codec" ? > > Right, I missed that. I'll add it in the next version, thanks! Great! Make sure to list that other patch as a dependency somewhere too to help Bjorn when he's able to apply. ;-) > > I was also looking at whether we should be enabling the wf_cam > > regulators for villager. I believe that answer is "no", > > I agree to keep them disabled. > > > but _also_ I believe that we should be _disabling_ the uf_cam > > regulators for villager, right? > > it is not clear yo me which regulator you have in mind for the UF cam, > could you clarify? I was thinking of the ones next to the rainbows and unicorns in the device tree. Oh wait, those were just in my imagination. Please disregard. -Doug
