Hi, On Thu, Mar 24, 2022 at 10:13 AM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote: > > Add a basic device tree for the herobrine villager board. > > Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx> > --- > > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../dts/qcom/sc7280-herobrine-villager-r0.dts | 274 ++++++++++++++++++ > 2 files changed, 275 insertions(+) Question: how does this interact with the patch: https://lore.kernel.org/r/20220316172814.v1.3.Iad21bd53f3ac14956b8dbbf3825fc7ab29abdf97@changeid/ Specifically, if that patch lands first don't you need to add a patch to turn on "pp3300_codec" ? I was also looking at whether we should be enabling the wf_cam regulators for villager. I believe that answer is "no", but _also_ I believe that we should be _disabling_ the uf_cam regulators for villager, right? > + "MOS_LAA_AS_EN", /* 90 */ > + "SD_CD_ODL", I was somewhat surprised that "SD_CD_ODL" was listed here since, diffing this with Herobrine, it appears that Villager doesn't have SD. I checked the schematics, though, and I can confirm that the GPIO is named this even if it just goes to a testpoint on the board. ;-) ...so I'm fine keeping it here. -Doug
