On Tue, Aug 12, 2014 at 2:05 PM, Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> wrote: > From: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> > > This patch moves ST specific sdio setup under a vendor id condition, > this will ensure that the ST specfic setup is not done on other vendor > like Qualcomm. > > Originally the issue was detected while testing WLAN ath6kl on IFC6410 > board with APQ8064 SOC. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> So instead of again checking hw_designer (I think that's a bit messy) and instead of having the flag bool sdio from patch 1, why not introduce 2 flags in vendor_data: bool st_sdio; bool qcom_sdio; > +++ b/drivers/mmc/host/mmci.c > @@ -828,7 +828,8 @@ static void mmci_start_data(struct mmci_host *host, struct mmc_data *data) > * otherwise the transfer will not start. The threshold > * depends on the rate of MCLK. > */ > - if (data->flags & MMC_DATA_WRITE && > + if (host->hw_designer == AMBA_VENDOR_ST && > + data->flags & MMC_DATA_WRITE && And this becomes just if (variant->st_sdio)... > (host->size < 8 || > (host->size <= 8 && host->mclk > 50000000))) > clk = host->clk_reg & ~variant->clkreg_enable; Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
