On Sun 20 Mar 06:06 CDT 2022, Krzysztof Kozlowski wrote: > The QCOM UFS driver requires an androidboot.bootdevice command line > argument matching the UFS device name. If the name is different, it > refuses to probe. Thise androidboot.bootdevice is provided by > stock/vendor (from an Android-based device) bootloader. > > This does not make sense from Linux point of view. Driver should be > able to boot regardless of bootloader. Driver should not depend on some > Android custom environment data. > > Cc: Luca Weiss <luca.weiss@xxxxxxxxxxxxx> > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > --- > > Not tested, please kindly provide tests. > > See also: > https://lore.kernel.org/linux-devicetree/f61abc2b-3ce8-7b1f-3d28-8a4a03ec58eb@xxxxxxxxxx/T/#u > --- > drivers/scsi/ufs/ufs-qcom.c | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c > index 0d2e950d0865..586c0e567ff9 100644 > --- a/drivers/scsi/ufs/ufs-qcom.c > +++ b/drivers/scsi/ufs/ufs-qcom.c > @@ -957,18 +957,6 @@ static const struct reset_control_ops ufs_qcom_reset_ops = { > .deassert = ufs_qcom_reset_deassert, > }; > > -#define ANDROID_BOOT_DEV_MAX 30 > -static char android_boot_dev[ANDROID_BOOT_DEV_MAX]; > - > -#ifndef MODULE > -static int __init get_android_boot_dev(char *str) > -{ > - strlcpy(android_boot_dev, str, ANDROID_BOOT_DEV_MAX); > - return 1; > -} > -__setup("androidboot.bootdevice=", get_android_boot_dev); > -#endif > - > /** > * ufs_qcom_init - bind phy with controller > * @hba: host controller instance > @@ -988,9 +976,6 @@ static int ufs_qcom_init(struct ufs_hba *hba) > struct resource *res; > struct ufs_clk_info *clki; > > - if (strlen(android_boot_dev) && strcmp(android_boot_dev, dev_name(dev))) > - return -ENODEV; > - > host = devm_kzalloc(dev, sizeof(*host), GFP_KERNEL); > if (!host) { > err = -ENOMEM; > -- > 2.32.0 >
