On Thu, Feb 17, 2022 at 2:33 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Thu, 17 Feb 2022 12:30:02 +0100, michael.srba@xxxxxxxxx wrote: > > From: Michael Srba <Michael.Srba@xxxxxxxxx> > > > > This patch adds bindings for the AHB bus which exposes the SCC block in > > the global address space. This bus (and the SSC block itself) is present > > on certain qcom SoCs. > > > > In typical configuration, this bus (as some of the clocks and registers > > that we need to manipulate) is not accessible to the OS, and the > > resources on this bus are indirectly accessed by communicating with a > > hexagon CPU core residing in the SSC block. In this configuration, the > > hypervisor is the one performing the bus initialization for the purposes > > of bringing the haxagon CPU core out of reset. > > > > However, it is possible to change the configuration, in which case this > > binding serves to allow the OS to initialize the bus. > > > > Signed-off-by: Michael Srba <Michael.Srba@xxxxxxxxx> > > --- > > NOTE: this applies against v5.17-rc4 just fine; dt_binding_check seems > > to have an issue with indentation, but the indentation looks correct > > to me as well as to local dt_binding_check; also, it seems that the > > rest of this series doesn't get applied before checking for compile > > errors on the example, which results in missing defines for > > GCC_IM_SLEEP, AGGRE2_SNOC_NORTH_AXI, SSC_XO, and SSC_CNOC_AHBS_CLK. > > > > CHANGES: > > - v2: fix issues caught by by dt-schema > > - v3: none > > - v4: address the issues pointed out in the review > > - v5: clarify type of additional properties; remove ssc_tlmm node for now > > - v6: none > > --- > > .../bindings/bus/qcom,ssc-block-bus.yaml | 143 ++++++++++++++++++ > > 1 file changed, 143 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/bus/qcom,ssc-block-bus.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/bus/qcom,ssc-block-bus.yaml:86:9: [warning] wrong indentation: expected 10 but found 8 (indentation) Please fix your yamllint install (or lack of). > dtschema/dtc warnings/errors: > Error: Documentation/devicetree/bindings/bus/qcom,ssc-block-bus.example.dts:39.32-33 syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:378: Documentation/devicetree/bindings/bus/qcom,ssc-block-bus.example.dt.yaml] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [Makefile:1398: dt_binding_check] Error 2 This failure can be ignored. I believe the problem is with my script applying series without a cover letter. However, series should have a cover letter. Rob
