On 15/02/2022 20:19, Sandeep Maheswaram wrote: > Add support for overriding SNPS phy tuning parameters in device tree > bindings. > > Signed-off-by: Sandeep Maheswaram <quic_c_sanm@xxxxxxxxxxx> > --- > .../devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml > index 0dfe691..44cf3bf 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml > @@ -50,6 +50,22 @@ properties: > vdda33-supply: > description: phandle to the regulator 3.3V supply node. > > + qcom,override_x0: Do not use underscore in properties, but hyphen. Just like everywhere in bindings. This does not look like description of hardware but hard-coding some register values. Bindings should rather describe the actual hardware parameters instead of values written into registers. Plus what other reviewers pointed about usefulness. Best regards, Krzysztof
