On 15/02/2022 22:19, Sandeep Maheswaram wrote:
Add support for overriding SNPS phy tuning parameters in device tree
bindings.
This does not really benefit the users and does not help developers.
Could you please change the dt bindings to specify values for
thresholds, durations, impedance, etc. The values should be represented
in the human units (e.g. us, Ohms, mV), not in the internal register
'bits' representation.
Signed-off-by: Sandeep Maheswaram <quic_c_sanm@xxxxxxxxxxx>
---
.../devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
index 0dfe691..44cf3bf 100644
--- a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
@@ -50,6 +50,22 @@ properties:
vdda33-supply:
description: phandle to the regulator 3.3V supply node.
+ qcom,override_x0:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: Override value for hs disconnect and squelch detector threshold.
+
+ qcom,override_x1:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: Override value for hs amplitude, pre-emphasis duration and amplitude.
+
+ qcom,override_x2:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: Override value for hs rise/fall time, cross over voltage, output impedance.
+
+ qcom,override_x3:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: Override value for ls/fs output impedance.
+
required:
- compatible
- reg
--
With best wishes
Dmitry
