-----Original Message-----
From: Marcel Holtmann <marcel@xxxxxxxxxxxx>
Sent: Friday, December 17, 2021 1:27 AM
To: Sai Teja Aluvala (Temp) (QUIC) <quic_saluvala@xxxxxxxxxxx>
Cc: Johan Hedberg <johan.hedberg@xxxxxxxxx>; mka@xxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-bluetooth@xxxxxxxxxxxxxxx; Hemant Gupta (QUIC) <quic_hemantg@xxxxxxxxxxx>; linux-arm-msm@xxxxxxxxxxxxxxx; quic_bgodavar <quic_bgodavar@xxxxxxxxxxx>; rjliao@xxxxxxxxxxxxxx; hbandi@xxxxxxxxxxxxxx; abhishekpandit@xxxxxxxxxxxx; mcchou@xxxxxxxxxxxx; PANICKER HARISH (Temp) (QUIC) <quic_pharish@xxxxxxxxxxx>
Subject: Re: [PATCH v3] Bluetooth: btqca: sequential validation
Hi Sai,
> Added Sequential validation support
> & patch command config
>
> Signed-off-by: Sai Teja Aluvala <quic_saluvala@xxxxxxxxxxx>
>
> v3:
> * removed rlen,rtype
> * Replaced kfree with kfree_skb
>
> v2:
> * Added static declaration
> * Addressed wrong indentation
> * Removed EDL_PATCH_CONFIG_CMD_LEN
> *
>
> v1:
> *Initial patch
> ---
> drivers/bluetooth/btqca.c | 48
> +++++++++++++++++++++++++++++++++++++++++++++++
> drivers/bluetooth/btqca.h | 2 ++
> 2 files changed, 50 insertions(+)
>
> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
> index be04d74..21830c6 100644
> --- a/drivers/bluetooth/btqca.c
> +++ b/drivers/bluetooth/btqca.c
> @@ -141,6 +141,51 @@ static int qca_read_fw_build_info(struct hci_dev *hdev)
> return err;
> }
>
> +static int qca_send_patch_config_cmd(struct hci_dev *hdev) {
> + struct sk_buff *skb;
> + int err = 0;
> + u8 cmd[] = {EDL_PATCH_CONFIG_CMD, 0x01, 0, 0, 0};
I am going to stop looking at this patch now. You are not able to address review comments.
[Sai] : i missed to update the comments. sorry for overlooking. I will update in next patch.
>From now on, I am only going to review QCA patches from people that are able to handle review comments.
Regards
Marcel
