On Mon, Dec 06, 2021 at 02:57:24PM -0800, Gaurav Kashyap wrote: > Implements the vops for generate, prepare and import key > apis and hooks it up the scm calls defined for them. > Key management has to be done from Qualcomm Trustzone as only > it can interface with HWKM. > > Signed-off-by: Gaurav Kashyap <quic_gaurkash@xxxxxxxxxxx> > --- > drivers/scsi/ufs/ufs-qcom-ice.c | 22 ++++++++ > drivers/scsi/ufs/ufs-qcom.c | 3 ++ > drivers/scsi/ufs/ufs-qcom.h | 12 +++++ > drivers/soc/qcom/qti-ice-common.c | 89 ++++++++++++++++++++++++++++--- > include/linux/qti-ice-common.h | 8 +++ > 5 files changed, 128 insertions(+), 6 deletions(-) Similarly to patch 6, it would be preferable to change qti-ice-common in a separate patch that precedes the ufs-qcom changes, if it's possible. If this is starting to result in too many patches, you might consider combining the patches that add generate/import/prepare with the patches that add derive_sw_secret. Splitting up patches between subsystems (when possible) is more important than splitting up the wrapped key feature itself, IMO. - Eric