On 23/05/14 10:12, Linus Walleij wrote:
On Thu, May 15, 2014 at 11:37 AM, <srinivas.kandagatla@xxxxxxxxxx> wrote:
From: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
This patch adds support to fbclk that is used to latch data and
cmd on some controllers like SD Card controller in Qcom SOC.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
(...)
Isn't this overkill?
I totally agree.
Initially I did do it the way you suggested, but wanted to be more
explicit in what its actually doing and I was also not sure if its Ok to
add more than one flag in clkreg_enable.
@@ -189,6 +192,7 @@ static struct variant_data variant_qcom = {
.clkreg = MCI_CLK_ENABLE,
- .clkreg_enable = MCI_QCOM_CLK_FLOWENA,
+ .clkreg_enable = MCI_QCOM_CLK_FLOWENA |
MCI_QCOM_CLK_FEEDBACK_CLK,
.clkreg_8bit_bus_enable = MCI_QCOM_CLK_WIDEBUS_8,
Isn't this achieveing exactly the same thing without the extra fields?
You unconditionally do it at every enable anyway, don't you?
I will fix it and send a new version.
Thanks,
srini
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
