On Mon, Mar 10, 2014 at 04:35:24PM -0500, Josh Cartwright wrote: > On Mon, Mar 10, 2014 at 01:47:41PM -0700, Andrew Morton wrote: > > Do we need a > > depends on REGMAP > > in Kconfig? > Good question. This driver already gets the REGMAP dependency through > it's parent (MFD_PM8XXX), which does 'select REGMAP'. > I recall there being some history as to why individual drivers shouldn't > explicitly depend on REGMAP, as it's the parent drivers/subsystem > responsibility to select it when needed, however I can't recall details. > Perhaps it's due to REGMAP not being a user-selectable option. Yeah, it should be a select of regmap because it's more of a helper library than a user visible feature and it's usually only on the MFD because you can't enable the function device without the core anyway.
Attachment:
signature.asc
Description: Digital signature
