On Mon, Mar 10, 2014 at 01:47:41PM -0700, Andrew Morton wrote: > On Mon, 10 Mar 2014 13:44:45 -0500 Josh Cartwright <joshc@xxxxxxxxxxxxxx> wrote: > > Now that the parent mfd driver has been made to work again, and has been > > reworked to create a regmap instance intended for it's children to use, > > rework the pm8xxx driver to use the regmap API for it's register > > accesses. > > Do we need a > > depends on REGMAP > > in Kconfig? Good question. This driver already gets the REGMAP dependency through it's parent (MFD_PM8XXX), which does 'select REGMAP'. I recall there being some history as to why individual drivers shouldn't explicitly depend on REGMAP, as it's the parent drivers/subsystem responsibility to select it when needed, however I can't recall details. Perhaps it's due to REGMAP not being a user-selectable option. (FWIW, I did force a build of this driver with !REGMAP, and it builds just fine with the regmap_write()/_read() stubs, but of course it wouldn't do anything meaningful at runtime) Thanks, Josh -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
