On Mon, Dec 16, 2013 at 3:03 PM, Olof Johansson <olof@xxxxxxxxx> wrote:
> On Mon, Dec 16, 2013 at 9:00 AM, Rob Clark <robdclark@xxxxxxxxx> wrote:
>
>> +
>> +/ {
>> + model = "Qualcomm APQ8064/IFC6410";
>> + compatible = "qcom,apq8064-ifc6410", "qcom,apq8064";
>> + interrupt-parent = <&intc>;
>
> [...]
>
>> diff --git a/arch/arm/mach-msm/board-dt.c b/arch/arm/mach-msm/board-dt.c
>> index 1f11d93..00796d1 100644
>> --- a/arch/arm/mach-msm/board-dt.c
>> +++ b/arch/arm/mach-msm/board-dt.c
>> @@ -23,6 +23,7 @@ static const char * const msm_dt_match[] __initconst = {
>> "qcom,msm8660-fluid",
>> "qcom,msm8660-surf",
>> "qcom,msm8960-cdp",
>> + "qcom,apq8064-ifc6410",
>
>
> We shouldn't enumerate boards here, it should probably list the
> second-level compatible instead. I.e. "qcom,apq8064" in this case.
oh, yeah, that does sound more sensible..
I guess I could split .dts up too, to separate parts that would apply
to all apq8064.. although not sure if that is overkill to do before
we have >1 apq8064 device supported..
BR,
-R
>
> -Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
