On 11/01, Janakiram Sistla wrote:
> On 1 November 2013 15:08, Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote:
> > + err = -ENOMEM;
> > + goto err_map;
> > + }
> > +
> > + l2_saw_base = of_iomap(l2_node, 0);
> > + if (!l2_saw_base) {
> > + err = -ENOMEM;
> > + goto err_l2_map;
> > + }
> > +
> > + /* Turn on the BHS, turn off LDO Bypass and power down LDO */
> > + reg_val = 0x403f0001;
> >
> I think patch looks more nice if this hard coding is defined in terms of
> macros
>
> > + writel_relaxed(reg_val, reg + APC_PWR_GATE_CTL);
> > +
> > + /* complete the above write before the delay */
> > + mb();
> > + /* wait for the bhs to settle */
> > + udelay(1);
> > +
> > + /* Turn on BHS segments */
> > + reg_val |= 0x3f << 1;
> >
> same as above
>
Ok. I'll see what I can do.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
