On 10/28, Mark Rutland wrote: > On Tue, Oct 29, 2013 at 01:21:57AM +0000, Stephen Boyd wrote: > > On 10/28/13 18:19, Mark Rutland wrote: > > > It might be worth commmenting inline as to what register each of these is > > > accessing. Inevitably the commit message will become harder to find and > > > associate with the code over time. > > > > > > Similarly for get_l2_indirect_reg. > > > > Do you mean with the "@" syntax in the assembly? The 80-character limit > > is out to get me. > > I probably didn't mean inline :) > > How about a block comment above the first asm block like: > > /* > * Select the L2 window by poking l2cpselr, then write to the window via > * l2cpdr. > */ > Ok sure. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
