On Tuesday 10 September 2013, Josh Cartwright wrote: > -#define TROUT_GPIO_INT_MASK0_REG (0x0c) > -#define TROUT_GPIO_INT_STAT0_REG (0x0e) > -#define TROUT_GPIO_INT_MASK1_REG (0x14) > -#define TROUT_GPIO_INT_STAT1_REG (0x10) > +#define TROUT_GPIO_INT_MASK0_REG IOMEM(0x0c) > +#define TROUT_GPIO_INT_STAT0_REG IOMEM(0x0e) > +#define TROUT_GPIO_INT_MASK1_REG IOMEM(0x14) > +#define TROUT_GPIO_INT_STAT1_REG IOMEM(0x10) This is wrong, the values above are offsets from TROUT_CPLD_BASE. Instead you need to make that constant an __iomem token and leave these as integers. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html