On Mon, 5 Dec 2011, Stephen Boyd wrote: > This teq was first introduced in bcc0f6a ([ARM] msm: clean up > iomap and devices, 2008-09-10). It seems that DEBUG_LL support on > MSM at the time had to remove the virtual mapping for the uart > base. Thus when the MMU was enabled the addruart macro returned 0 > and the senduart macro would test for 0 and do nothing. It was a > simple way to turn off DEBUG_LL when the MMU was enabled. > > The virtual mapping was added back in 6339f66 (msm: make > debugging UART (for DEBUG_LL) configurable, 2009-11-02) but the > patch forgot to remove the teq here. So as it stands the teq has > been useless for two years and DEBUG_LL works fine without it. > > Cc: Nicolas Pitre <nico@xxxxxxxxxxx> > Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx> Acked-by: Nicolas Pitre <nico@xxxxxxxxxx> > --- > arch/arm/mach-msm/include/mach/debug-macro.S | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-msm/include/mach/debug-macro.S b/arch/arm/mach-msm/include/mach/debug-macro.S > index 3ffd866..0e05f88 100644 > --- a/arch/arm/mach-msm/include/mach/debug-macro.S > +++ b/arch/arm/mach-msm/include/mach/debug-macro.S > @@ -30,8 +30,7 @@ > @ Write the 1 character to UARTDM_TF > str \rd, [\rx, #0x70] > #else > - teq \rx, #0 > - strne \rd, [\rx, #0x0C] > + str \rd, [\rx, #0x0C] > #endif > .endm > > -- > Sent by an employee of the Qualcomm Innovation Center, Inc. > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. > -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
