On 11/09/2011 05:07 PM, Harini Jayaraman wrote: > This bus driver supports the QUP SPI hardware controller in the Qualcomm > MSM SOCs. The Qualcomm Universal Peripheral Engine (QUP) is a general > purpose data path engine with input/output FIFOs and an embedded SPI > mini-core. The driver currently supports only FIFO mode. > > Signed-off-by: Harini Jayaraman <harinij@xxxxxxxxxxxxxx> > --- > drivers/spi/Kconfig | 10 + > drivers/spi/Makefile | 1 + > drivers/spi/msm_spi_qsd.h | 436 +++++++++++++ > drivers/spi/spi-qsd.c | 1144 +++++++++++++++++++++++++++++++++ > include/linux/platform_data/msm_spi.h | 19 + > 5 files changed, 1610 insertions(+), 0 deletions(-) > create mode 100644 drivers/spi/msm_spi_qsd.h > create mode 100644 drivers/spi/spi-qsd.c > create mode 100644 include/linux/platform_data/msm_spi.h A few high-level comments to start. Let's drop 'qsd' from all the names. We haven't used that naming convention for several years now. Better to just call this 'spi-qup.[ch]'. Also, please update the copyright dates. This driver existed before 2011. Thanks. - Bryan -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
