On 11/08/11 11:08, Nicolas Pitre wrote: > Independently from this patch, I was wondering about this code: > >> + .macro senduart, rd, rx >> +#ifdef CONFIG_MSM_HAS_DEBUG_UART_HS >> + @ Write the 1 character to UARTDM_TF >> + str \rd, [\rx, #0x70] >> +#else >> teq \rx, #0 >> strne \rd, [\rx, #0x0C] >> +#endif >> .endm > Why testing for zero in the #else part? The upper level code should > never call this macro with a null byte. > I was wondering the same thing, I don't know why that test for null is there. I will dust off the old 7201a (literally) and see what I can find out. It certainly looks unnecessary. -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
