On Thu, Jun 09 2011, Daniel Walker wrote:
>> diff --git a/arch/arm/mach-msm/timer.c b/arch/arm/mach-msm/timer.c
>> index 38b95e9..b3579fe 100644
>> --- a/arch/arm/mach-msm/timer.c
>> +++ b/arch/arm/mach-msm/timer.c
>> @@ -100,7 +100,7 @@ static cycle_t msm_read_timer_count(struct clocksource *cs)
>> {
>> struct msm_clock *clk = container_of(cs, struct msm_clock, clocksource);
>>
>> - return readl(clk->global_counter);
>> + return readl(clk->global_counter) >> clk->shift;
>> }
>
> Could you comment in the code with something explaining what the shift
> is doing.
Probably best to describe this near msm_clock's definition (or
MSM_DGT_SHIFT), since it is a bit unclear what these values are.
A good (but short) description of how the shifts and even why.
The comment shouldn't be in the function body (CodingStyle, chapter 8).
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
