On 05/26/2011 11:37 AM, Stephen Boyd wrote:
On 5/25/2011 10:15 PM, Anirudh Ghayal wrote:
diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c
new file mode 100644
index 0000000..4694c4e
--- /dev/null
+++ b/drivers/rtc/rtc-pm8xxx.c
+
+/**
+ * struct pm8xxx_rtc rtc driver internal structure
This is missing a dash '-'.
+static int pm8xxx_read_wrapper(struct pm8xxx_rtc *rtc_dd, u8 *rtc_val,
+ int base, int count)
+{
+ int i, rc;
+ struct device *parent = rtc_dd->rtc_dev->parent;
+
+ for (i = 0; i< count; i++) {
+ rc = pm8xxx_readb(parent, base + i,&rtc_val[i]);
+ if (rc< 0) {
+ dev_err(rtc_dd->rtc_dev, "PMIC read failed\n");
I still think these printks are useless when you already have better
printks at the call sites on the error path.
I actually don't mind seeing the entire error flow in the log.
pm8xxx_readb() might report a failure but it is sometimes help to know
who the caller was that may have triggered the error.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
