On Wed, May 18 2011, H Hartley Sweeten wrote: > On Wednesday, May 18, 2011 2:51 PM, David Brown wrote: >> >> The gpiomux.h header contains some SOC ifdefs. However, the API that >> is actually used by the GPIO driver only uses two functions that are >> general. Move these general definitions into a public header file. >> >> Signed-off-by: David Brown <davidb@xxxxxxxxxxxxxx> >> --- >> arch/arm/mach-msm/gpio.c | 2 +- >> arch/arm/mach-msm/gpiomux.h | 17 +---------------- >> include/linux/msm_gpiomux.h | 38 ++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 40 insertions(+), 17 deletions(-) >> create mode 100644 include/linux/msm_gpiomux.h > > The msm_gpiomux.h header appears to be very "msm" specific, especially > with the #ifdef CONFIG_MSM_GPIOMUX in it. Wouldn't it be cleaner to > just move it to arch/arm/mach-msm/include/mach/msm_gpiomux.h? > > I don't see a reason why this header needs/should be available for > the general public in /include/linux. Agreed. David -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
