Re: [PATCH V2 2/2] mtd: msm_nand: Add initial msm nand driver support.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2011-04-18 at 09:32 +0200, Matthieu CASTET wrote:
> Hi,
> 
> Murali Nalajala a Ãcrit :
> > Add initial msm nand driver support for Qualcomm MSM platforms.
> > This driver is capable of handling both 2k and 4k page support
> > nand devices.
> > 
> > This driver was originally developed by Arve HjÃnnevÃg at google.
> > Its source is available at
> > http://android.git.kernel.org/?p=kernel/msm.git under
> > android-msm-2.6.35 branch.
> > 
> > CC: Dima Zavin <dima@xxxxxxxxxxx>
> > CC: Brian Swetland <swetland@xxxxxxxxxx>
> > CC: Arve HjÃnnevÃg <arve@xxxxxxxxxxx>
> > Signed-off-by: Murali Nalajala <mnalajal@xxxxxxxxxxxxxx>
> > ---
> > Changes in V2
> > * Turn most of the pr_info() calls into pr_debug().
> > 
> >  drivers/mtd/devices/Kconfig    |   11 +
> >  drivers/mtd/devices/Makefile   |    1 +
> >  drivers/mtd/devices/msm_nand.c | 1597 ++++++++++++++++++++++++++++++++++++++++
> >  drivers/mtd/devices/msm_nand.h |   77 ++
> >  4 files changed, 1686 insertions(+), 0 deletions(-)
> >  create mode 100644 drivers/mtd/devices/msm_nand.c
> >  create mode 100644 drivers/mtd/devices/msm_nand.h
> > 
> 
> For the record, I am not sure it is a great idea to make nand drivers
> independent of the nand layer.

This is not acceptable. Nand drivers should use the nand_base framework.
If the framework is limiting, buggy, slow, etc for your case (which is
quite possible) - the framework should be improved.

-- 
Best Regards,
Artem Bityutskiy (ÐÑÑÑÐ ÐÐÑÑÑÐÐÐ)

--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux