On Sat, 2011-04-16 at 11:20 +0300, Artem Bityutskiy wrote: > > > +#define MSM_NAND_REG(off) (msm_nand_phys + (off)) > > > + > > > +#define MSM_NAND_FLASH_CMD MSM_NAND_REG(0x0000) > > > +#define MSM_NAND_ADDR0 MSM_NAND_REG(0x0004) > > > > > > Could you please make the macros to take the "struct msm_nand_chip > > > *chip" argument instead, and store the pase address there. Do not hide > > > the fact that those macros are actually functions, not constant - this > > > is error prone. > > > > > > Besides, I'm do not know your HW, but if you have several controllers > > > with various base addresses - your driver won't work. > > > > you are correct, we have multiple controllers, which breaks this logic > > in future. > > So then make your macros to accept the base address as an argument > instead please. Or better make macros to be constants, and always use something like base + MSM_NAND_FLASH_CMD - this is the standard approach. -- Best Regards, Artem Bityutskiy (ÐÐÑÑÑÐÐÐ ÐÑÑÑÐ) -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
