Re: [PATCH 0/7] Nexus One Support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 21, 2011 at 11:05:54PM +0200, Pekka Enberg wrote:
> 
> On Fri, Jan 21, 2011 at 10:49 PM, Daniel Walker <dwalker@xxxxxxxxxxxxxx> wrote:
> > I'll add this list into the commit text ..
> 
> So why is everyone bitching at Daniel when he's doing something the
> Android folks should have done themselves a long time ago?

Two wrongs don't make a right.  And it's not like not submitting
changes is wrong, although granted it's not ideal.  (I'd say removing
attribution from a git commit is even worse.  If you're doing the
equivalent of a cherry pick, you should preserve the Author field.
Even if you're doing some cleanup work, as the maintainer I generally
preserve the Author line, and will simply add the fact that I did some
cleanup to the commit body.  The question is who did more work; the
person who originally submitted the code, or the person who did the
cleanup.)

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux