On Thu, 2011-01-20 at 18:25 -0800, Joe Perches wrote: > On Thu, 2011-01-20 at 17:58 -0800, Daniel Walker wrote: > > On Thu, 2011-01-20 at 17:41 -0800, Joe Perches wrote: > > > On Thu, 2011-01-20 at 16:55 -0800, Daniel Walker wrote: > > > > On Thu, 2011-01-20 at 16:42 -0800, Dima Zavin wrote: > > > > > You are not the author of any of these patches. Where are the author > > > > > attributions for the team that actually wrote this code? > > > > In the commit text.. The author field is used to denote who authored the > > > > commit, which in this case is me. > > > You have that wrong. > > > Author and Committer are different git fields. > > > http://www.kernel.org/pub/software/scm/git/docs/user-manual.html > > > > > > * an author: The name of the person responsible for this change, > > > together with its date. > > > * a committer: The name of the person who actually created the > > > commit, with the date it was done. This may be different from > > > the author, for example, if the author was someone who wrote a > > > patch and emailed it to the person who used it to create the > > > commit. > > I'm not even sure how to make these different, but in this case it > > doesn't matter because the "committer" as you defined it above is more > > than one person .. > > Not really, no. > > The authors may be different, but the first git > committer of the patch is different. > > The committer is the person that does a git commit > either directly with git commit or git am. > > If a git tree is pulled by someone else, the initial > committer name remains on the commit. > > You should keep the original patch author names and > add your own "Signed-off-by:" and not claim authorship > of the patches themselves. This isn't what's happening tho. In maintainer land if someone forwards you a patch then you leave the original author on the patch. They wrote the patch and your just forwarding it on up the ladder. This isn't the case with these patches.. I crafted each of the commit I have authorship on, no one forwarded those commits to me. I'm not taking authorship credit for any thing I didn't create, although I an giving credit to the place which gave me the raw material which was Google. From my experience this is how it's done in Linux .. Daniel -- Sent by an consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
