On Mon, Dec 06, 2010 at 06:52:00PM -0800, Daniel Walker wrote:
> On Mon, 2010-12-06 at 22:29 +0000, Mark Brown wrote:
> > > +static int reg_debug_enable_set(void *data, u64 val)
> > > +{
> > > + int err_info;
> > > + if (IS_ERR(data) || data == NULL) {
> > > + pr_err("Function Input Error %ld\n", PTR_ERR(data));
> > Please Try To Make Your Log Messages A Bit More Descriptive And
> > Typographically Correct - I'd not expect a user to have a hope of
> > figuring out what's gone wrong here. That said, I suspect you're
> > looking for BUG_ON() here...
> Could we do WARN_ON() here? Unless this is a really serious problem.
It means we've managed to let the user open a file without setting up
the private data for the file correctly which is a pretty bad bug which
we'd never expect to see at runtime unless there was a clear kernel bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
