On Mon, 2010-12-06 at 22:29 +0000, Mark Brown wrote:
> > +static int reg_debug_enable_set(void *data, u64 val)
> > +{
> > + int err_info;
> > + if (IS_ERR(data) || data == NULL) {
> > + pr_err("Function Input Error %ld\n", PTR_ERR(data));
>
> Please Try To Make Your Log Messages A Bit More Descriptive And
> Typographically Correct - I'd not expect a user to have a hope of
> figuring out what's gone wrong here. That said, I suspect you're
> looking for BUG_ON() here...
Could we do WARN_ON() here? Unless this is a really serious problem.
Daniel
--
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
