On Fri, Jul 30, 2010 at 11:15:24PM -0400, Benjamin Herrenschmidt wrote: > On Thu, 2010-07-29 at 10:26 +0200, Arnd Bergmann wrote: > > Exactly, thanks for the clarification. I also didn't realize that > > there > > is now an include/linux/iommu.h file that only describes the PCI > > SR-IOV > > interfaces, unlike the generic IOMMU support that we have in your > > include/linux/dma-mapping.h file. > > > > Maybe we should rename linux/iommu.h to something more specific so we > > can reduce this confusion in the future. > > Hrm, indeed I just noticed that. Pretty gross... it should definitly be > renamed, is will caused endless confusion with unrelated iommu.h and > iommu_* interfaces which represent something different. The first direction to go should be trying to unify all the different iommu* interfaces into the iommu-api. The generic api will definitly need to be extended for that, but since it is an in-kernel interface thats no problem. -- Joerg Roedel - AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632 -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html