On Thu, Jul 22, 2010 at 03:57:30PM -0700, Jeff Ohlstein wrote: > Unless gic_ack_irq is called from __do_IRQ, interrupt should not > be disabled in the ack function. Disabling the interrupt causes > handle_edge_irq to never enable it again. The GIC doesn't use handle_edge_irq. Anyway, this change is correct since gic_ack_irq is currently doing a maskack, when it should be just an ack. However, since GENERIC_HARDIRQS_NO__DO_IRQ is always true on ARM, I don't see a need to add the ifndef. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html