On Tue, Jun 15, 2010 at 17:11, Gregory Bean wrote: > +config GPIO_MSM7200A > + tristate "Qualcomm MSM7200A SoC GPIO support" > + depends on GPIOLIB > + help > + Say yes here to support GPIO functionality on Qualcomm's > + MSM chipsets which descend from the MSM7200a: > + MSM7x01(a), MSM7x25, MSM7x27, MSM7x30, QSD8x50(a). you should mention the module name in the help text > +static int msm_gpio_probe(struct platform_device *dev) should have __devinit markings > +static int msm_gpio_remove(struct platform_device *dev) __devexit > + .remove = msm_gpio_remove, __devexit_p() > +postcore_initcall(msm_gpio_init); does this really need to be postcore rather than module ? -mike -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
