Re: [RFC PATCH v3 12/12] selftests: add ncdevmem, netcat for devmem TCP

To: Mina Almasry <almasrymina@xxxxxxxxxx>
Subject: Re: [RFC PATCH v3 12/12] selftests: add ncdevmem, netcat for devmem TCP
From: Jakub Kicinski <kuba@xxxxxxxxxx>
Date: Fri, 10 Nov 2023 15:17:18 -0800
Cc: netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-kselftest@xxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, linaro-mm-sig@xxxxxxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Jesper Dangaard Brouer <hawk@xxxxxxxxxx>, Ilias Apalodimas <ilias.apalodimas@xxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, David Ahern <dsahern@xxxxxxxxxx>, Willem de Bruijn <willemdebruijn.kernel@xxxxxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, Sumit Semwal <sumit.semwal@xxxxxxxxxx>, "Christian König" <christian.koenig@xxxxxxx>, Shakeel Butt <shakeelb@xxxxxxxxxx>, Jeroen de Borst <jeroendb@xxxxxxxxxx>, Praveen Kaligineedi <pkaligineedi@xxxxxxxxxx>, Stanislav Fomichev <sdf@xxxxxxxxxx>
In-reply-to: <20231106024413.2801438-13-almasrymina@google.com>
References: <20231106024413.2801438-1-almasrymina@google.com> <20231106024413.2801438-13-almasrymina@google.com>

On Sun,  5 Nov 2023 18:44:11 -0800 Mina Almasry wrote:
> +	if (ynl_subscribe(*ys, "mgmt"))
> +		goto err_close;

Why? :)

References:
- [RFC PATCH v3 00/12] Device Memory TCP
  - From: Mina Almasry
- [RFC PATCH v3 12/12] selftests: add ncdevmem, netcat for devmem TCP
  - From: Mina Almasry