On Fri, Aug 19, 2022 at 8:34 PM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
> It takes the helpers and INIT_C_CC into new header (termios-internal.h),
> with defaults being in linux/termios-internal.h, unless an arch-specific
> variant is provided in asm/termios-internal.h (only alpha and sparc end
> up needing that). Files that need that stuff (all 4 of them) include
> linux/termios-internal.h.
I don't see anything obviously wrong here, and my main reaction is
actually that I wish this went a bit further, and moved the whole
kernel_termios_to_user_termios stuff into C code rather than having
them in headers.
I don't think it's really worth inlining those things, and I wonder if
we could just have the default "just copy directly to/from user space"
as __weak functions, and then allow sparc and alpha to override them?
Linus
