On 8/19/22 19:57, Huacai Chen wrote: > PCI_LOONGSON is a mandatory for LoongArch and it is selected in Kconfig > unconditionally, but its dependency PCI_QUIRKS is missing and may cause > a build error when "make randconfig": > > arch/loongarch/pci/acpi.c: In function 'pci_acpi_setup_ecam_mapping': >>> arch/loongarch/pci/acpi.c:103:29: error: 'loongson_pci_ecam_ops' undeclared (first use in this function) > 103 | ecam_ops = &loongson_pci_ecam_ops; > | ^~~~~~~~~~~~~~~~~~~~~ > arch/loongarch/pci/acpi.c:103:29: note: each undeclared identifier is reported only once for each function it appears in > > Kconfig warnings: (for reference only) > WARNING: unmet direct dependencies detected for PCI_LOONGSON > Depends on [n]: PCI [=y] && (MACH_LOONGSON64 [=y] || COMPILE_TEST [=y]) && (OF [=y] || ACPI [=y]) && PCI_QUIRKS [=n] > Selected by [y]: > - LOONGARCH [=y] > > Fix it by selecting PCI_QUIRKS unconditionally, too. > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Signed-off-by: Huacai Chen <chenhuacai@xxxxxxxxxxx> Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # build-tested Thanks. > --- > arch/loongarch/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig > index 4abc9a28aba4..26aeb1408e56 100644 > --- a/arch/loongarch/Kconfig > +++ b/arch/loongarch/Kconfig > @@ -111,6 +111,7 @@ config LOONGARCH > select PCI_ECAM if ACPI > select PCI_LOONGSON > select PCI_MSI_ARCH_FALLBACKS > + select PCI_QUIRKS > select PERF_USE_VMALLOC > select RTC_LIB > select SMP -- ~Randy
