Hi Anshuman, On Wed, Jun 9, 2021 at 6:59 AM Anshuman Khandual <anshuman.khandual@xxxxxxx> wrote: > Currently most platforms define pmd_pgtable() as pmd_page() duplicating the > same code all over. Instead just define a default value i.e pmd_page() for > pmd_pgtable() and let platforms override when required via <asm/pgtable.h>. > All the existing platform that override pmd_pgtable() have been moved into > their respective <asm/pgtable.h> header in order to precede before the new > generic definition. This makes it much cleaner with reduced code. > Signed-off-by: Anshuman Khandual <anshuman.khandual@xxxxxxx> > --- > This patch applies on linux-next (20210608) as there is a merge conflict > dependency on the following commit. > > 40762590e8be ("mm: define default value for FIRST_USER_ADDRESS"). > > This patch has been built tested across multiple platforms. > > Changes in V2: > > - Changed m68k per Geert Thanks for the update! > arch/m68k/include/asm/mcf_pgalloc.h | 2 -- > arch/m68k/include/asm/mcf_pgtable.h | 2 ++ > arch/m68k/include/asm/motorola_pgalloc.h | 1 - > arch/m68k/include/asm/motorola_pgtable.h | 2 ++ > arch/m68k/include/asm/sun3_pgalloc.h | 1 - > arch/m68k/include/asm/sun3_pgtable.h | 2 ++ Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds