Re: [asm-generic:compat-alloc-user-space-9 6/41] net/ethtool/ioctl.c:815:9: error: implicit declaration of function 'in_ia32_syscall'; did you mean 'in_compat_syscall'?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Arnd Bergmann <arnd@xxxxxxxx>
Subject: Re: [asm-generic:compat-alloc-user-space-9 6/41] net/ethtool/ioctl.c:815:9: error: implicit declaration of function 'in_ia32_syscall'; did you mean 'in_compat_syscall'?
From: Christoph Hellwig <hch@xxxxxx>
Date: Thu, 20 May 2021 07:19:51 +0200
Cc: kernel test robot <lkp@xxxxxxxxx>, kbuild-all@xxxxxxxxxxxx, linux-arch <linux-arch@xxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>
In-reply-to: <CAK8P3a3ytGKfRftRqC5OaGTxNfxX5-qpbXdGG9AYHcRJFMB-RA@mail.gmail.com>
References: <202105200456.B8lcITGX-lkp@intel.com> <CAK8P3a3ytGKfRftRqC5OaGTxNfxX5-qpbXdGG9AYHcRJFMB-RA@mail.gmail.com>
User-agent: Mutt/1.5.17 (2007-11-01)

On Wed, May 19, 2021 at 10:33:08PM +0200, Arnd Bergmann wrote:
>  static bool ethtool_translate_compat(void)
>  {
> -#ifdef CONFIG_X86_64
> +#if defined(CONFIG_X86_64) && !defined(CONFIG_UML)
>         /* On x86, translation is needed for i386 but not x32 */
>         return in_ia32_syscall();
>  #else

Please just use compat_need_64bit_alignment_fixup() instead.

Follow-Ups:
- Re: [asm-generic:compat-alloc-user-space-9 6/41] net/ethtool/ioctl.c:815:9: error: implicit declaration of function 'in_ia32_syscall'; did you mean 'in_compat_syscall'?
  - From: Arnd Bergmann

References:
- [asm-generic:compat-alloc-user-space-9 6/41] net/ethtool/ioctl.c:815:9: error: implicit declaration of function 'in_ia32_syscall'; did you mean 'in_compat_syscall'?
  - From: kernel test robot
- Re: [asm-generic:compat-alloc-user-space-9 6/41] net/ethtool/ioctl.c:815:9: error: implicit declaration of function 'in_ia32_syscall'; did you mean 'in_compat_syscall'?
  - From: Arnd Bergmann

Prev by Date: Re: [PATCH RFC 0/3] riscv: Add DMA_COHERENT support
Next by Date: Re: [PATCH RFC 0/3] riscv: Add DMA_COHERENT support
Previous by thread: Re: [asm-generic:compat-alloc-user-space-9 6/41] net/ethtool/ioctl.c:815:9: error: implicit declaration of function 'in_ia32_syscall'; did you mean 'in_compat_syscall'?
Next by thread: Re: [asm-generic:compat-alloc-user-space-9 6/41] net/ethtool/ioctl.c:815:9: error: implicit declaration of function 'in_ia32_syscall'; did you mean 'in_compat_syscall'?
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Newbies] [x86 Platform Driver] [Netdev] [Linux Wireless] [Netfilter] [Bugtraq] [Linux Filesystems] [Yosemite Discussion] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper]