On Sat, Mar 27, 2021 at 09:29:26AM +0200, Andy Shevchenko wrote: > On Saturday, March 27, 2021, Syed Nayyar Waris <syednwaris@xxxxxxxxx> wrote: > > > On Fri, Mar 26, 2021 at 11:32 PM Andy Shevchenko > > <andy.shevchenko@xxxxxxxxx> wrote: > > > > > > On Sat, Mar 6, 2021 at 4:08 PM Syed Nayyar Waris <syednwaris@xxxxxxxxx> > > wrote: > > > > > > > + bitmap_set_value(old, 64, state[0], 32, 0); > > > > + bitmap_set_value(old, 64, state[1], 32, 32); > > > > > > Isn't it effectively bitnap_from_arr32() ? > > > > > > > + bitmap_set_value(new, 64, state[0], 32, 0); > > > > + bitmap_set_value(new, 64, state[1], 32, 32); > > > > > > Ditto. > > > > > > -- > > > With Best Regards, > > > Andy Shevchenko > > > > Hi Andy, > > > > With bitmap_set_value() we are also specifying the offset (or start) > > position too. so that the remainder of the array remains unaffected. I > > think it would not be feasible to use bitmap_from/to_arr32() here. > > > You have hard coded start and nbits parameters to 32. How is it not the > same? Would these four lines become something like this: bitmap_from_arr32(old, state, 64); ... bitmap_from_arr32(new, state, 64); Sincerely, William Breathitt Gray
Attachment:
signature.asc
Description: PGP signature
