On Thu, Oct 8, 2020 at 3:52 PM Hajime Tazaki <thehajime@xxxxxxxxx> wrote: > > > On Thu, 08 Oct 2020 00:10:23 +0900, > Anton Ivanov wrote: > > > > > > On 07/10/2020 16:03, Johannes Berg wrote: > > > On Wed, 2020-10-07 at 17:02 +0200, Johannes Berg wrote: > > >> On Wed, 2020-10-07 at 15:53 +0100, Anton Ivanov wrote: > > >>> These are actually different on different architectures. These look > > >>> like the x86 values. > > Those variables are based on tools/um/include/lkl/asm-generic/errno.h, > which is generated from include/uapi/asm-generic/errno.h, which LKL > kernel eats for its values. > > This is the part of patch 12/21. > > > >>> IMHO a kernel strerror() would be the right way of dealing with this > > >>> in the long term (i understand that we cannot call the platform one, > > >>> because it may be different from the internal Linux errors). It will > > >>> be useful in a lot of other places. > > >>> > > >>> If we leave it as is, we need to make this arch specific at some > > >>> point. > > So, this particular code does not contain arch specific part I > believe. > # Tavi, correct me if I'm wrong. > I think Anton was saying that we should do it properly with C99 to avoid potential issues with changes in configuration and I agree that is the way to go.
