On Wed, 2020-10-07 at 17:02 +0200, Johannes Berg wrote:
> On Wed, 2020-10-07 at 15:53 +0100, Anton Ivanov wrote:
> > These are actually different on different architectures. These look
> > like the x86 values.
> >
> > IMHO a kernel strerror() would be the right way of dealing with this
> > in the long term (i understand that we cannot call the platform one,
> > because it may be different from the internal Linux errors). It will
> > be useful in a lot of other places.
> >
> > If we leave it as is, we need to make this arch specific at some
> > point.
> >
> > > +
> > > +static const char * const lkl_err_strings[] = {
> > > + "Success",
> > > + "Operation not permitted",
>
> Might be possible to more or less address this (except for arch-specific
> errors that don't always exist) but using C99 initializers?
>
> [0] = "Success",
> [EPERM] = "Operation not permitted",
> ..
But, on the other hand, is it needed at all? I don't think the kernel
ever prints out the actual string ...
johannes
