Re: [PATCH v5 00/21] kprobes: Unify kretprobe trampoline handlers and make kretprobe lockless

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2 Sep 2020 09:02:26 +0200
peterz@xxxxxxxxxxxxx wrote:

> On Wed, Sep 02, 2020 at 09:37:39AM +0900, Masami Hiramatsu wrote:
> > On Tue, 1 Sep 2020 21:08:08 +0200
> > Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> > 
> > > On Sat, Aug 29, 2020 at 09:59:49PM +0900, Masami Hiramatsu wrote:
> > > > Masami Hiramatsu (16):
> > > >       kprobes: Add generic kretprobe trampoline handler
> > > >       x86/kprobes: Use generic kretprobe trampoline handler
> > > >       arm: kprobes: Use generic kretprobe trampoline handler
> > > >       arm64: kprobes: Use generic kretprobe trampoline handler
> > > >       arc: kprobes: Use generic kretprobe trampoline handler
> > > >       csky: kprobes: Use generic kretprobe trampoline handler
> > > >       ia64: kprobes: Use generic kretprobe trampoline handler
> > > >       mips: kprobes: Use generic kretprobe trampoline handler
> > > >       parisc: kprobes: Use generic kretprobe trampoline handler
> > > >       powerpc: kprobes: Use generic kretprobe trampoline handler
> > > >       s390: kprobes: Use generic kretprobe trampoline handler
> > > >       sh: kprobes: Use generic kretprobe trampoline handler
> > > >       sparc: kprobes: Use generic kretprobe trampoline handler
> > > >       kprobes: Remove NMI context check
> > > >       kprobes: Free kretprobe_instance with rcu callback
> > > >       kprobes: Make local used functions static
> > > > 
> > > > Peter Zijlstra (5):
> > > >       llist: Add nonatomic __llist_add() and __llist_dell_all()
> > > >       kprobes: Remove kretprobe hash
> > > >       asm-generic/atomic: Add try_cmpxchg() fallbacks
> > > >       freelist: Lock less freelist
> > > >       kprobes: Replace rp->free_instance with freelist
> > > 
> > > This looks good to me, do you want me to merge them through -tip? If so,
> > > do we want to try and get them in this release still?
> > 
> > Yes, thanks. For the kretprobe missing issue, we will need the first half
> > (up to "kprobes: Remove NMI context check"), so we can split the series
> > if someone think the lockless is still immature.
> 
> Ok, but then lockdep will yell at you if you have that enabled and run
> the unoptimized things.

Oh, does it warn for all spinlock things in kprobes if it is unoptimized?
Hmm, it has to be noted in the documentation.

Thank you,


-- 
Masami Hiramatsu <mhiramat@xxxxxxxxxx>



[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux